-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Allow ConfigBinder to bind arrays to Singular elements #57204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
beb621a
Allow ConfigBinder to bind arrays to Singular elements
vidommet c9e7ef1
Add AppContext switch for old behavior. Extracted functionality into …
vidommet 64c8ee2
Fix comment
vidommet 01cbca8
Added test with disabling the behavior
vidommet c77ff33
Split unit tests, remove empty space
vidommet cfb5c69
Explicit variable name
vidommet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Allow ConfigBinder to bind arrays to Singular elements
When trying to bind a collection of type `T`, ConfigBinder will now try to bind to the current object instead of children objects when the provided configuration doesn't contain an array. This change allows elements that are not arrays to be bound to arrays. For example, a type string[] can now be bound to "key" along with "key:0".
- Loading branch information
commit beb621a84f5a5f5d62bd91d880f6ade7066e17d5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract this into a helper method and use it in both places? Also it would be nice to write a comment or two about what this is doing, and why.