Skip to content

Fix ARM64 unsigned div by const perf regression #57372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pentp wants to merge 3 commits into from
Closed

Fix ARM64 unsigned div by const perf regression #57372

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
976bf2a
Fix ARM64 unsigned div by const perf regression
pentp Aug 13, 2021
6dba123
Try fix formatting
pentp Aug 13, 2021
9a9d09d
Try to make formatting happy
pentp Aug 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try fix formatting
  • Loading branch information
@pentp
pentp committed Aug 13, 2021
commit 6dba123aa102b65d19cd9deaa18229212c4a2737
3 changes: 2 additions & 1 deletion src/coreclr/jit/lower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5261,7 +5261,7 @@ bool Lowering::LowerUnsignedDivOrMod(GenTreeOp* divMod)
#ifdef TARGET_ARM64
&& !simpleMul
#endif
)
)
{
adjustedDividend = comp->gtNewCastNode(TYP_I_IMPL, adjustedDividend, true, TYP_U_IMPL);
BlockRange().InsertBefore(divMod, adjustedDividend);
Expand Down Expand Up @@ -5290,6 +5290,7 @@ bool Lowering::LowerUnsignedDivOrMod(GenTreeOp* divMod)
// The existing node will later be transformed into a GT_RSZ/GT_SUB that
// computes the final result. This way don't need to find and change the use
// of the existing node.

#ifdef TARGET_ARM64
genTreeOps mulOp = simpleMul ? GT_MULWIDE : GT_MULHI; // 64-bit MUL is more expensive than UMULL on ARM64
#else
Expand Down