Skip to content

Eliminate temporary byte array allocations in the static constructor of IPAddress. #57397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 2 commits into from
Aug 16, 2021
Merged

Eliminate temporary byte array allocations in the static constructor of IPAddress. #57397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93dc0fe
Eliminate temporary byte array allocations in the static constructor …
teo-tsirpanis Aug 14, 2021
b889e0e
Alias `IPv6None` to `IPv6Any`.
teo-tsirpanis Aug 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/libraries/System.Net.Primitives/src/System/Net/IPAddress.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ public class IPAddress

internal const uint LoopbackMaskHostOrder = 0xFF000000;

public static readonly IPAddress IPv6Any = new IPAddress(new byte[] { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }, 0);
public static readonly IPAddress IPv6Loopback = new IPAddress(new byte[] { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1 }, 0);
public static readonly IPAddress IPv6None = new IPAddress(new byte[] { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }, 0);
public static readonly IPAddress IPv6Any = new IPAddress((ReadOnlySpan<byte>) new byte[] { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }, 0);
public static readonly IPAddress IPv6Loopback = new IPAddress((ReadOnlySpan<byte>) new byte[] { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1 }, 0);
public static readonly IPAddress IPv6None = IPv6Any;

private static readonly IPAddress s_loopbackMappedToIPv6 = new IPAddress(new byte[] { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 255, 127, 0, 0, 1 }, 0);
private static readonly IPAddress s_loopbackMappedToIPv6 = new IPAddress((ReadOnlySpan<byte>) new byte[] { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 255, 127, 0, 0, 1 }, 0);

/// <summary>
/// For IPv4 addresses, this field stores the Address.
Expand Down Expand Up @@ -644,7 +644,7 @@ public IPAddress MapToIPv4()

private sealed class ReadOnlyIPAddress : IPAddress
{
public ReadOnlyIPAddress(byte[] newAddress) : base(newAddress)
public ReadOnlyIPAddress(ReadOnlySpan<byte> newAddress) : base(newAddress)
{ }
}
}
Expand Down