Skip to content

[Group 3] Enable nullable annotations for Microsoft.Extensions.Configuration #57414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
safern merged 24 commits into from
Oct 13, 2021
Merged

[Group 3] Enable nullable annotations for Microsoft.Extensions.Configuration #57414

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ad2ea3d
Annotate src
maxkoshevoi Aug 14, 2021
04bc30b
Annotate ref
maxkoshevoi Aug 14, 2021
65f47b2
Add net6 to Configuration.Abstractions
maxkoshevoi Aug 14, 2021
44d0ac0
Fix tests
maxkoshevoi Aug 14, 2021
1226d7e
Merge branch 'main' into mk/43605-Configuration
maxkoshevoi Aug 15, 2021
07cc6a8
Merge branch 'main' into mk/43605-Configuration
maxkoshevoi Aug 15, 2021
802a753
Merge branch 'main' into mk/43605-Configuration
maxkoshevoi Aug 16, 2021
051b15b
Merge branch 'main' into mk/43605-Configuration
maxkoshevoi Aug 26, 2021
5a7a6d3
DisableImplicitAssemblyReferences
maxkoshevoi Aug 26, 2021
9bde07c
Merge branch 'main' into mk/43605-Configuration
maxkoshevoi Sep 8, 2021
4945112
TryGet can return null
maxkoshevoi Sep 16, 2021
330dc3a
Merge branch 'main' into mk/43605-Configuration
maxkoshevoi Sep 16, 2021
f320ed0
new()
maxkoshevoi Sep 16, 2021
7cbd323
Merge remote-tracking branch 'upstream/main' into mk/43605-Configuration
eerhardt Oct 6, 2021
b9a0a93
Fix merge error
eerhardt Oct 6, 2021
e5228aa
InvalidOperationException
maxkoshevoi Oct 7, 2021
1c583ec
Source.Stream DisallowNull
maxkoshevoi Oct 7, 2021
a45a821
Revert unnecessary changes
maxkoshevoi Oct 8, 2021
d33438a
More message into resources
maxkoshevoi Oct 8, 2021
2ca692a
Configuration DisallowNull
maxkoshevoi Oct 8, 2021
4813528
MaybeNullWhen(false)
maxkoshevoi Oct 8, 2021
581c024
Revert "MaybeNullWhen(false)"
maxkoshevoi Oct 8, 2021
ff9af93
Remove MaybeNullWhen
maxkoshevoi Oct 11, 2021
3790ba6
NotNullWhen
maxkoshevoi Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DisableImplicitAssemblyReferences
  • Loading branch information
@maxkoshevoi
maxkoshevoi committed Aug 26, 2021
commit 5a7a6d3956480165cddbed2518f21109b0de62eb
6 changes: 2 additions & 4 deletions ...ibraries/Microsoft.Extensions.Configuration/ref/Microsoft.Extensions.Configuration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@
<ProjectReference Include="$(LibrariesProjectRoot)Microsoft.Extensions.Primitives\ref\Microsoft.Extensions.Primitives.csproj" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
<Reference Include="System.Linq" />
<Reference Include="System.Runtime" />
<Reference Include="System.Collections" />
<Reference Include="System.Threading" />
<ProjectReference Include="$(LibrariesProjectRoot)System.Collections\ref\System.Collections.csproj" />
<ProjectReference Include="$(LibrariesProjectRoot)System.Runtime\ref\System.Runtime.csproj" />
</ItemGroup>
</Project>
9 changes: 2 additions & 7 deletions ...ibraries/Microsoft.Extensions.Configuration/src/Microsoft.Extensions.Configuration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
<TargetFrameworks>$(NetCoreAppCurrent);netstandard2.0;net461</TargetFrameworks>
<Nullable>enable</Nullable>
<EnableDefaultItems>true</EnableDefaultItems>
<!-- Use targeting pack references instead of granular ones in the project file. -->
<DisableImplicitAssemblyReferences>false</DisableImplicitAssemblyReferences>
<PackageDescription>Implementation of key-value pair based configuration for Microsoft.Extensions.Configuration. Includes the memory configuration provider.</PackageDescription>
</PropertyGroup>

Expand All @@ -12,11 +14,4 @@
<ProjectReference Include="$(LibrariesProjectRoot)Microsoft.Extensions.Primitives\src\Microsoft.Extensions.Primitives.csproj" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
<Reference Include="System.Linq" />
<Reference Include="System.Runtime" />
<Reference Include="System.Collections" />
<Reference Include="System.Threading" />
</ItemGroup>

</Project>