Skip to content

[Group 3] Enable nullable annotations for Microsoft.Extensions.Configuration.Tests #57422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxkoshevoi wants to merge 8 commits into from
Closed

[Group 3] Enable nullable annotations for Microsoft.Extensions.Configuration.Tests #57422

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f645989
Annotate FunctionalTests
maxkoshevoi Aug 14, 2021
8c97f90
Annotate tests
maxkoshevoi Aug 14, 2021
31576e7
Update ConfigurationRootTest.cs
maxkoshevoi Aug 14, 2021
d8bdc49
Update ConfigurationTests.cs
maxkoshevoi Aug 15, 2021
c3212e1
Fix tests
maxkoshevoi Aug 15, 2021
a8eb1ff
Update ConfigurationTests.cs
maxkoshevoi Aug 24, 2021
a50e331
Merge branch 'main' into mk/43605-configuration-tests
maxkoshevoi Aug 24, 2021
fdd1cc3
Merge branch 'main' into mk/43605-configuration-tests
maxkoshevoi Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update ConfigurationTests.cs
  • Loading branch information
@maxkoshevoi
maxkoshevoi committed Aug 15, 2021
commit d8bdc49f0c73941db9af853e9b309a1aca1311e2
10 changes: 5 additions & 5 deletions src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ public void OnLoadErrorWillBeCalledOnIniLoadError()
_fileSystem.WriteFile("error.ini", @"IniKey1=IniValue1
IniKey1=IniValue2");

FileConfigurationProvider provider = null;
FileConfigurationProvider? provider = null;
Exception? error = null;
Action<FileLoadExceptionContext> loadError = c =>
{
Expand Down Expand Up @@ -452,7 +452,7 @@ public void OnLoadErrorCanIgnoreErrors()
{
_fileSystem.WriteFile("error.json", @"{""JsonKey1"": ");

FileConfigurationProvider provider = null;
FileConfigurationProvider? provider = null;
Action<FileLoadExceptionContext> jsonLoadError = c =>
{
provider = c.Provider;
Expand Down Expand Up @@ -490,7 +490,7 @@ public void CanSetValuesAndReloadValues()
foreach (var provider in configurationBuilder.Sources)
{
Assert.Equal("NewValue",
(provider as FileConfigurationProvider).Get("CommonKey1:CommonKey2:CommonKey3:CommonKey4"));
(provider as FileConfigurationProvider)?.Get("CommonKey1:CommonKey2:CommonKey3:CommonKey4"));
}

// Recover values by reloading
Expand All @@ -505,7 +505,7 @@ public void CanSetValuesAndReloadValues()
foreach (var provider in configurationBuilder.Sources)
{
Assert.Equal("NewValue",
(provider as FileConfigurationProvider).Get("CommonKey1:CommonKey2:CommonKey3:CommonKey4"));
(provider as FileConfigurationProvider)?.Get("CommonKey1:CommonKey2:CommonKey3:CommonKey4"));
}

// Recover values by reloading
Expand Down Expand Up @@ -834,7 +834,7 @@ public void LoadIncorrectJsonFile_ThrowException()
_fileSystem.WriteFile(_jsonFile, json);

var exception = Assert.Throws<InvalidDataException>(() => CreateBuilder().AddJsonFile(_jsonFile).Build());
Assert.Contains("Could not parse the JSON file.", exception.InnerException.Message);
Assert.Contains("Could not parse the JSON file.", exception.InnerException?.Message);
}

[Fact]
Expand Down