Skip to content

[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.CommandLine #57432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eerhardt merged 14 commits into from
Nov 19, 2021
Merged

[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.CommandLine #57432

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
eb99a97
Annotate
maxkoshevoi Aug 15, 2021
3af608f
Add net6 to parent projects
maxkoshevoi Aug 15, 2021
8be0609
Merge branch 'main' into mk/43605-Configuration-CommandLine
maxkoshevoi Aug 16, 2021
81b49ec
Merge branch 'main' into mk/43605-Configuration-CommandLine
maxkoshevoi Aug 26, 2021
dbd2ace
DisableImplicitAssemblyReferences
maxkoshevoi Aug 26, 2021
8113acb
Merge branch 'main' into mk/43605-Configuration-CommandLine
maxkoshevoi Sep 8, 2021
a2e7fb0
Merge branch 'main' into mk/43605-Configuration-CommandLine
maxkoshevoi Oct 6, 2021
e8bf057
Merge branch 'main' into mk/43605-Configuration-CommandLine
maxkoshevoi Oct 13, 2021
af10396
Merge branch 'main' into mk/43605-Configuration-CommandLine
maxkoshevoi Nov 19, 2021
87fa7c8
NetCoreAppMinimum
maxkoshevoi Nov 19, 2021
53dbbe6
configureSource is nullable
maxkoshevoi Nov 19, 2021
fbfb3ba
Add NetCoreAppMinimum to System.Runtime and System.Collections
maxkoshevoi Nov 19, 2021
70c095a
Revert "Add NetCoreAppMinimum to System.Runtime and System.Collections"
maxkoshevoi Nov 19, 2021
99dae39
Fix NetCoreAppMinimum build
eerhardt Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DisableImplicitAssemblyReferences
  • Loading branch information
@maxkoshevoi
maxkoshevoi committed Aug 26, 2021
commit dbd2ace2c18cdce19313fd5e75275d5a35678b8d
5 changes: 2 additions & 3 deletions ...sions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
<ProjectReference Include="$(LibrariesProjectRoot)Microsoft.Extensions.Configuration.Abstractions\ref\Microsoft.Extensions.Configuration.Abstractions.csproj" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
<Reference Include="System.Collections" />
<Reference Include="System.Linq" />
<Reference Include="System.Runtime" />
<ProjectReference Include="$(LibrariesProjectRoot)System.Collections\ref\System.Collections.csproj" />
<ProjectReference Include="$(LibrariesProjectRoot)System.Runtime\ref\System.Runtime.csproj" />
</ItemGroup>
</Project>
8 changes: 2 additions & 6 deletions ...sions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
<TargetFrameworks>$(NetCoreAppCurrent);netstandard2.0;net461</TargetFrameworks>
<Nullable>enable</Nullable>
<EnableDefaultItems>true</EnableDefaultItems>
<!-- Use targeting pack references instead of granular ones in the project file. -->
<DisableImplicitAssemblyReferences>false</DisableImplicitAssemblyReferences>
<PackageDescription>Command line configuration provider implementation for Microsoft.Extensions.Configuration.</PackageDescription>
</PropertyGroup>

Expand All @@ -12,10 +14,4 @@
<ProjectReference Include="$(LibrariesProjectRoot)Microsoft.Extensions.Configuration.Abstractions\src\Microsoft.Extensions.Configuration.Abstractions.csproj" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
<Reference Include="System.Collections" />
<Reference Include="System.Linq" />
<Reference Include="System.Runtime" />
</ItemGroup>

</Project>