Skip to content

Fix Length for ReadOnlySequence created out of sliced Memory owned by MemoryManager #57479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 4 commits into from
Aug 16, 2021
Merged

Fix Length for ReadOnlySequence created out of sliced Memory owned by MemoryManager #57479

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
203b4ff
write a failing test
adamsitnik Aug 16, 2021
aff7e30
change MemoryTestSequenceFactory to test this scenario as well
adamsitnik Aug 16, 2021
c57990d
fix
adamsitnik Aug 16, 2021
07048a3
there is no need to use unmanaged memory
adamsitnik Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change MemoryTestSequenceFactory to test this scenario as well
  • Loading branch information
@adamsitnik
adamsitnik committed Aug 16, 2021
commit aff7e307c69d44162e82a86c41b16ed732709a2f
6 changes: 5 additions & 1 deletion src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceFactory.byte.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ internal class MemoryTestSequenceFactory : ReadOnlySequenceFactory<T>
{
public override ReadOnlySequence<T> CreateOfSize(int size)
{
return CreateWithContent(new T[size]);
#if DEBUG
return new ReadOnlySequence<T>(new ReadOnlyMemory<T>(new T[size + 1]).Slice(1)); // #57472
#else
return new ReadOnlySequence<T>(new ReadOnlyMemory<T>(new T[size]));
#endif
Copy link
Member

@stephentoub stephentoub Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally prefer for the ifdef to be around the minimal thing that's different, so that it's clear what exactly the difference is. e.g.

ReadOnlyMemory<T> m = new T[size + 1];
#if DEBUG
m = m.Slice(1);
#endif
return new ReadOnlySequence<T>(m);

}

public override ReadOnlySequence<T> CreateWithContent(T[] data)
Expand Down