Skip to content

Give tvOS a special value for Personal/MyDocuments #57508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
directhex merged 36 commits into from
Aug 24, 2021
Merged

Give tvOS a special value for Personal/MyDocuments #57508

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
6354dd0
Use a different Personal folder on tvOS, and a test that it works
Aug 16, 2021
0ee7a71
Run this PR on device, the error does not happen on sim
Aug 16, 2021
5854dfc
CI fixes
Aug 16, 2021
7473c19
Nullable
Aug 16, 2021
877258f
Test on devices
Aug 16, 2021
b032fc0
Just run one test to save disk space
Aug 16, 2021
43573f7
Tweak to run only 1 test and make sure DevTeamProvisioning is right
Aug 17, 2021
a39e472
Horrible hack to check something in CI
Aug 17, 2021
392a09b
Merge branch 'tvos-specialdirectories' of github.com:directhex/runtim…
Aug 17, 2021
cfcb6dc
Revert all changes. Run as-is in CI to see if it's my changes to blame
Aug 17, 2021
c50a1af
nonsense
Aug 17, 2021
7e7d49b
Set temp path to a valid location
Aug 18, 2021
064670d
Fix AppDomainTests.ExecuteAssembly to copy files to a valid place
Aug 18, 2021
a48cfe7
Don't expect HOME to work on tvOS
Aug 18, 2021
26354d7
We cannot get exit code from tvOS device, so runonly tests don't work
Aug 18, 2021
4ee0555
Revert infra changes made to enable CI of this PR, which passes now o…
Aug 18, 2021
75bf9e2
Merge remote-tracking branch 'origin/main' into tvos-specialdirectories
Aug 18, 2021
07660e2
Add NSTemporaryDirectory interop function and supporting cast
Aug 18, 2021
e57d693
Merge remote-tracking branch 'origin/tvos-specialdirectories' into tv…
Aug 18, 2021
4b49b07
forgot a void
Aug 19, 2021
84609fc
Requested changes from Alex
Aug 19, 2021
b936dc1
Merge remote-tracking branch 'origin/main' into tvos-specialdirectories
Aug 20, 2021
5ad98b9
Merge remote-tracking branch 'origin/main' into tvos-specialdirectories
Aug 23, 2021
9ebb6b0
Don't use nullable
Aug 23, 2021
fc2cf38
Revert AppDominTests changes, not clear they're needed
Aug 23, 2021
74ddcff
namespace
Aug 23, 2021
a619fa7
Update src/libraries/System.Private.CoreLib/src/System/IO/Path.Unix.i…
directhex Aug 23, 2021
33788e1
Revert unused props
Aug 23, 2021
a3d96ed
Update src/libraries/System.Private.CoreLib/src/System/IO/Path.Unix.i…
directhex Aug 23, 2021
0baf69f
Update src/libraries/System.Private.CoreLib/src/System/IO/Path.Unix.i…
directhex Aug 23, 2021
e85a9e4
Update src/libraries/System.Private.CoreLib/src/System/IO/Path.Unix.i…
directhex Aug 23, 2021
6f338fa
Update src/libraries/System.Private.CoreLib/src/System/IO/Path.Unix.N…
directhex Aug 23, 2021
eb5706a
Changes squashing other changes, bleh
Aug 23, 2021
67a6c1d
Update src/libraries/System.Private.CoreLib/src/System/IO/Path.Unix.i…
directhex Aug 23, 2021
e3cbd8c
error CA1805: Member 's_defaultTempPath' is explicitly initialized to…
Aug 23, 2021
538b631
Merge remote-tracking branch 'origin/main' into tvos-specialdirectories
Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
We cannot get exit code from tvOS device, so runonly tests don't work
  • Loading branch information
Jo Shields committed Aug 18, 2021
commit 26354d748018c4c96214a79e260c11d287b81af2
2 changes: 1 addition & 1 deletion src/libraries/sendtohelixhelp.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@
<TestTarget>$(AppleTestTarget)</TestTarget>
</XHarnessAppBundleToTest>
<!-- Create work items for run-only apps -->
<XHarnessAppBundleToTest Condition="Exists('$(TestArchiveRoot)runonly')" Include="$([System.IO.Directory]::GetDirectories('$(TestArchiveRoot)runonly', '*.app', System.IO.SearchOption.AllDirectories))" >
<XHarnessAppBundleToTest Condition="Exists('$(TestArchiveRoot)runonly') and '$(TargetOS)' != 'tvOS'" Include="$([System.IO.Directory]::GetDirectories('$(TestArchiveRoot)runonly', '*.app', System.IO.SearchOption.AllDirectories))" >
Copy link
Member

@akoeplinger akoeplinger Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should work on tvOS right? please file an issue so we follow up to reenable the "run-only" apps

Copy link
Contributor Author

@directhex directhex Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference I have for runonly not working on tvOS is something @steveisok said in chat - Steve, is there an actual record of "runonly doesn't work on tvOS"?

Copy link
Member

@steveisok steveisok Aug 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't get a return code from an iOS or tvOS device, which the functional tests expect.

Not sure if there's an issue in xharness. @premun would know.

Copy link
Member

@premun premun Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't think this is supported in mlaunch. I will confirm this on Monday

Copy link
Member

@akoeplinger akoeplinger Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that were the case then this would fail on iOS too (and it doesn't seem to).

Copy link
Contributor Author

@directhex directhex Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akoeplinger have you tested on device? Right now we have no Apple device runs anywhere

Copy link
Member

@akoeplinger akoeplinger Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I thought we ran it on the staging pipeline? anyway, if it doesn't work on iOS we should exclude it too :)

Copy link
Contributor Author

@directhex directhex Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No iOS_ runs in runtime-staging.yml.

It likely doesn't work on iOS either, but it'll take me ages to check on device via CI.

I could exclude it too, here, though. Or exclude neither since we don't know the state of things for sure.

Copy link
Member

@premun premun Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can test this for you on an iPhone. Can you give me instructions on how to build the app?

<!-- The sample app doesn't need test runner -->
<IncludesTestRunner>false</IncludesTestRunner>
<!-- The sample's C# Main method returns 42 so it should be considered by xharness as a success -->
Expand Down