Skip to content

Conversation

@steveisok
Copy link
Member

Since HttpClientHandler on mobile can support both the underlying native handler and SocketsHttpHandler, it doesn't make sense to always throw PNSE on some methods due to only the native handler not supporting them.

Fixes #55986

Since HttpClientHandler on mobile can support both the underlying native handler and SocketsHttpHandler, it doesn't make sense to always throw PNSE on some methods due to only the native handler not supporting them.

Fixes dotnet#55986
@ghost
Copy link

ghost commented Aug 17, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Aug 17, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Since HttpClientHandler on mobile can support both the underlying native handler and SocketsHttpHandler, it doesn't make sense to always throw PNSE on some methods due to only the native handler not supporting them.

Fixes #55986

Author: steveisok
Assignees: -
Labels:

area-System.Net.Http, new-api-needs-documentation

Milestone: -

@marek-safar
Copy link
Contributor

@akoeplinger was this fix backported?

@steveisok
Copy link
Member Author

@marek-safar It got in before the snap.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS/tvOS/MacCatalyst: some HttpClientHandler properties behave differently now

4 participants