Skip to content

[mono] For cross builds targeting s390x use proper objcopy #57566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lambdageek merged 1 commit into from
Aug 17, 2021
Merged

[mono] For cross builds targeting s390x use proper objcopy #57566

lambdageek merged 1 commit into from
Aug 17, 2021

Conversation

@stefan-sf-ibm
Copy link
Contributor

@stefan-sf-ibm stefan-sf-ibm commented Aug 17, 2021

While cross compiling for target s390x use s390x-linux-gnu-objcopy instead of objcopy.

CC'ing @uweigand

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-Build-mono labels Aug 17, 2021
lambdageek
lambdageek approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uweigand looks good?

@uweigand
Copy link
Contributor

uweigand commented Aug 17, 2021

@uweigand looks good?

Yes, this LGTM.

@lambdageek lambdageek merged commit 616ace3 into dotnet:main Aug 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2021
@stefan-sf-ibm stefan-sf-ibm deleted the objcopy-s390x branch March 25, 2022 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageek lambdageek lambdageek approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

No one assigned

Labels

area-Build-mono community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stefan-sf-ibm @uweigand @lambdageek