Skip to content

Fix QUIC ConnectionState NRE in HandleEventConnectionClose #57655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarnaViire merged 2 commits into from
Aug 19, 2021
Merged

Fix QUIC ConnectionState NRE in HandleEventConnectionClose #57655

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50c5948
Fix QUIC ConnectionState NRE in HandleEventConnectionClose
CarnaViire Aug 18, 2021
25c7be3
Remove unnecessary Dispose
CarnaViire Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove unnecessary Dispose
  • Loading branch information
@CarnaViire
CarnaViire committed Aug 18, 2021
commit 25c7be34621ae688c857a60d0357075e3ad85a3f
1 change: 0 additions & 1 deletion src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ internal MsQuicStream(MsQuicConnection.State connectionState, QUIC_STREAM_OPEN_F

if (!connectionState.TryAddStream(this))
{
_state.Handle?.Dispose();
throw new ObjectDisposedException(nameof(QuicConnection));
}
// this assignment should be done before StreamOpenDelegate to prevent NRE in HandleEventConnectionClose
Expand Down