Skip to content

[release/6.0] JIT: don't clone loops where init or limit is a cast local #57685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffschwMSFT merged 2 commits into from
Aug 19, 2021
Merged

[release/6.0] JIT: don't clone loops where init or limit is a cast local #57685

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5803f1e
JIT: don't clone loops where init or limit is a cast local
AndyAyersMS Aug 17, 2021
4c3e5b6
Apply suggestions from code review
AndyAyersMS Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: SingleAccretion <[email protected]>
  • Loading branch information
@AndyAyersMS @SingleAccretion
2 people authored and github-actions committed Aug 18, 2021
commit 4c3e5b65ae2baa19a87be3a8b5830a2a8b42a8be
4 changes: 2 additions & 2 deletions src/coreclr/jit/loopcloning.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,7 +969,7 @@ bool Compiler::optDeriveLoopCloningConditions(unsigned loopNum, LoopCloneContext
{
// initVar >= 0
const unsigned initLcl = loop->lpVarInit;
if (!genActualTypeIsInt(lvaGetDesc(initLcl)->lvType))
if (!genActualTypeIsInt(lvaGetDesc(initLcl)))
{
JITDUMP("> Init var V%02u not compatible with TYP_INT\n", initLcl);
return false;
Expand Down Expand Up @@ -1000,7 +1000,7 @@ bool Compiler::optDeriveLoopCloningConditions(unsigned loopNum, LoopCloneContext
else if (loop->lpFlags & LPFLG_VAR_LIMIT)
{
const unsigned limitLcl = loop->lpVarLimit();
if (!genActualTypeIsInt(lvaGetDesc(limitLcl)->lvType))
if (!genActualTypeIsInt(lvaGetDesc(limitLcl)))
{
JITDUMP("> Limit var V%02u not compatible with TYP_INT\n", limitLcl);
return false;
Expand Down