Skip RuntimeEventSource tests on wasm and android #57890
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
src/tests/issues.targets
Outdated
| <ItemGroup Condition=" '$(TargetArchitecture)' == 'wasm' " > | ||
| <ExcludeList Include="$(XunitTestBinBase)/tracing/eventcounter/runtimeeventsource/runtimeeventsource*"> | ||
| <Issue>AppContext switch events are not available on mono Android and wasm</Issue> | ||
| </ExcludeList> |
There was a problem hiding this comment.
Just curious what's special about these two, e.g. they are available on iOS?
There was a problem hiding this comment.
Not sure, still investigating. I suspect it doesn't work on iOS either, but we may not run those tests.
There was a problem hiding this comment.
Yeah -- it looks like the runtime tests are only run on Mono for Android and wasm. I don't even see x64 there, which suprises me.
I'm going to blanket disable this on Mono for now. It wasn't a requirement and I would want to do a lot more work before stating this should work in any Mono environment.
|
Hello @agocke! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
* Skip RuntimeEventSource tests on wasm and android * Skip tests without using issues.targets * Disable test for mono (cherry picked from commit 454ac57)
…ches (#57847) * Add event to RuntimeEventSource for AppContext switches Fixes #56142 * Respond to PR comments * Add preliminary tests * Respond to PR comments * Add keyword * Fix tests * Remove AppContext EventSource support on browser * forgot using * Fix error reporting, add comments * Respond to PR comments * Refactor tests * Fix case where s_switches is null * Fix bug * Print more info for test failure * Typo * Fix lab failure * Respond to PR comments * Respond to PR comments * Typo * Respond to PR comments * Skip RuntimeEventSource tests on wasm and android (#57890) * Skip RuntimeEventSource tests on wasm and android * Skip tests without using issues.targets * Disable test for mono (cherry picked from commit 454ac57) Co-authored-by: Andy Gocke <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
2 participants
Fixes #57886