Skip to content

Handle file-scoped namespaces in Logging Source Generator #57894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maryamariyan merged 2 commits into from
Sep 10, 2021
Merged

Handle file-scoped namespaces in Logging Source Generator #57894

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ba0da9
Handle file-scoped namespaces
martincostello Aug 22, 2021
5c22a98
Merge branch 'main' into Fix-Logging-SourceGen-FileScoped-NS
martincostello Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into Fix-Logging-SourceGen-FileScoped-NS
  • Loading branch information
@martincostello
martincostello authored Aug 31, 2021
commit 5c22a985daf9315234ae3c71b555c3f6ad682e76
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<ProjectServicingConfiguration Include="Microsoft.NETCore.App.Ref" PatchVersion="0" />
</ItemGroup>
<PropertyGroup>
<!-- For source generator support we need to target a pinned version in order to be able to run on older versions of Roslyn -->
<!-- For source generator support we are targeting the latest version of Roslyn for now, until we can support multi-targeting -->
<MicrosoftCodeAnalysisCSharpWorkspacesVersion>4.0.0-3.final</MicrosoftCodeAnalysisCSharpWorkspacesVersion>
<MicrosoftCodeAnalysisVersion>4.0.0-3.final</MicrosoftCodeAnalysisVersion>
</PropertyGroup>
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.