[wasm][debugger] Fixing assert while debugging. #58028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsWhen trying to evaluate DebuggerProxyAttribute of a generic type <T, K>, it was working only for one parameter . TODO: Add a test case.
|
Member
Author
|
/backport to release/6.0-rc1 |
Contributor
|
Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1163344818 |
lewing
approved these changes
Aug 24, 2021
radical
reviewed
Aug 24, 2021
| var genericTypeId = await GetTypeByName(sessionId, typeToSearch, token); | ||
| if (genericTypeId < 0) | ||
| return null; | ||
| methodId = await GetMethodIdByName(sessionId, genericTypeId, ".ctor", token); |
Member
There was a problem hiding this comment.
Won't this fail to find the correct .ctor, if there is more than one on the type?
Also, DebuggerTypeProxy accepts a string arg with the type name. That doesn't have to be in this PR though.
radical
approved these changes
Aug 24, 2021
Member
radical
left a comment
radical
left a comment
There was a problem hiding this comment.
My comments can be addressed in a separate PR. LGTM!
Member
|
ci hit #58062 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to evaluate DebuggerProxyAttribute of a generic type <T, K>, it was working only for one parameter .
Fixes #58021