Skip to content

[release/6.0] Additional statistics when a ServiceProvider is created #58030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericstj merged 1 commit into from
Aug 24, 2021
Merged

[release/6.0] Additional statistics when a ServiceProvider is created #58030

ericstj merged 1 commit into from
Aug 24, 2021

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 24, 2021 •
edited by eerhardt
Loading

Backport of #57753 to release/6.0

/cc @eerhardt @allantargino

Customer Impact

We added a few diagnostics to DependencyInjection in 6.0 to help users debug / analyze their applications. This change adds 2 more stats to the information:

  • closedGenericsServices
  • openGenericsServices

Testing

New automated tests were written.

Risk

Low

@allantargino
Additional statistics when a ServiceProvider is created
f2a2806 
* Number of open generics
* Number of closed generics

fix #52364
@ghost
Copy link

ghost commented Aug 24, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #57753 to release/6.0

/cc @eerhardt @allantargino

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Extensions-DependencyInjection
Milestone: -

@eerhardt
Copy link
Member

eerhardt commented Aug 24, 2021

cc @danmoseley for approval

@eerhardt eerhardt added this to the 6.0.0 milestone Aug 24, 2021
@danmoseley
Copy link
Member

danmoseley commented Aug 24, 2021

approved for release/6.0 -- low risk, augments diagnostics consistent with recent efforts in this area for 6.0

@ghost
Copy link

ghost commented Aug 24, 2021

Hello @eerhardt!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 24, 2021

Apologies, while this PR appears ready to be merged, it looks like release/6.0 is a protected branch and I have not been granted permission to perform the merge.

1 similar comment
@ghost
Copy link

ghost commented Aug 24, 2021

Apologies, while this PR appears ready to be merged, it looks like release/6.0 is a protected branch and I have not been granted permission to perform the merge.

@ericstj ericstj merged commit a83c78f into release/6.0 Aug 24, 2021
@danmoseley danmoseley deleted the backport/pr-57753-to-release/6.0 branch August 24, 2021 20:51
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees

No one assigned

Labels

area-Extensions-DependencyInjection

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@eerhardt @danmoseley @ericstj @allantargino