Skip to content

Fix nullability bug in System.Diagnostics.TraceSource Switch #58095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephentoub merged 1 commit into from
Aug 25, 2021
Merged

Fix nullability bug in System.Diagnostics.TraceSource Switch #58095

stephentoub merged 1 commit into from
Aug 25, 2021

Conversation

@buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Aug 25, 2021 •
edited
Loading

Related to #58026 (comment)

The base constructor was annotated incorrectly, defaultSwitchValue cannot be null

@buyaa-n buyaa-n requested review from AArnott and stephentoub August 25, 2021 03:41
@ghost
Copy link

ghost commented Aug 25, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Aug 25, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to System.Diagnostics.TraceSource

The base constructor was annotated incorrectly, defaultSwitchValue cannot be null

Author: buyaa-n
Assignees: -
Labels:

area-System.Diagnostics.Tracing, new-api-needs-documentation
Milestone: -

@danmoseley
Copy link
Member

danmoseley commented Aug 25, 2021

Reasonable to port to 6.0

krwq
krwq approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this

@stephentoub stephentoub merged commit 12beab4 into dotnet:main Aug 25, 2021
@stephentoub
Copy link
Member

stephentoub commented Aug 25, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2021

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1166189956

@github-actions github-actions bot mentioned this pull request Aug 25, 2021
Merged
@buyaa-n buyaa-n deleted the nullability-bug branch August 25, 2021 16:33
@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krwq krwq krwq approved these changes

@stephentoub stephentoub stephentoub approved these changes

@AArnott AArnott Awaiting requested review from AArnott

Assignees

No one assigned

Labels

area-System.Diagnostics.Tracing new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@buyaa-n @danmoseley @stephentoub @krwq