Skip to content

[Stress] Enable POST by disabling InternalServerError suppression #58110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alnikola wants to merge 5 commits into from
Closed

[Stress] Enable POST by disabling InternalServerError suppression #58110

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cda0b74
[Stress] Enable POST by disabling InternalServerError suppression
alnikola Aug 25, 2021
b22674e
Remove catch side
alnikola Aug 25, 2021
faa0f34
Throw IGNORE for HTTP/2 only
alnikola Aug 27, 2021
9467130
Revert IGNORE catch
alnikola Aug 27, 2021
ae8564d
Remove whitespaces
alnikola Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Throw IGNORE for HTTP/2 only
  • Loading branch information
@alnikola
alnikola authored Aug 27, 2021
commit faa0f34ba6e7714a407b2b9416b18cafb221399b
6 changes: 6 additions & 0 deletions src/libraries/System.Net.Http/tests/StressTests/HttpStress/ClientOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,12 @@ public static (string name, Func<RequestContext, Task> operation)[] Operations =

private static void ValidateStatusCode(HttpResponseMessage m, HttpStatusCode expectedStatus = HttpStatusCode.OK)
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/55261")]
if (m.StatusCode == HttpStatusCode.InternalServerError && m.Version == HttpVersion.Version30)
{
throw new Exception("IGNORE");
}

Copy link
Contributor

@antonfirsov antonfirsov Aug 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: whitespaces:

Suggested change

Copy link
Contributor Author

@alnikola alnikola Aug 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done already :)

if (m.StatusCode != expectedStatus)
{
throw new Exception($"Expected status code {expectedStatus}, got {m.StatusCode}");
Expand Down