Skip to content

[release/6.0] Remove usage of [AggressiveOptimization] #58253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 1 commit into from
Sep 1, 2021
Merged

[release/6.0] Remove usage of [AggressiveOptimization] #58253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ....Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectDefaultConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ internal class ObjectDefaultConverter<T> : JsonObjectConverter<T> where T : notn
{
internal override bool CanHaveIdMetadata => true;

#if NET6_0_OR_GREATER
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
#endif
internal override bool OnTryRead(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options, ref ReadStack state, [MaybeNullWhen(false)] out T value)
{
JsonTypeInfo jsonTypeInfo = state.Current.JsonTypeInfo;
Expand Down Expand Up @@ -249,9 +246,6 @@ internal override bool OnTryRead(ref Utf8JsonReader reader, Type typeToConvert,
return true;
}

#if NET6_0_OR_GREATER
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
#endif
internal sealed override bool OnTryWrite(
Utf8JsonWriter writer,
T value,
Expand Down
6 changes: 0 additions & 6 deletions src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,6 @@ internal virtual bool OnTryRead(ref Utf8JsonReader reader, Type typeToConvert, J
/// <remarks>Note that the value of <seealso cref="HandleNull"/> determines if the converter handles null JSON tokens.</remarks>
public abstract T? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options);

#if NET6_0_OR_GREATER
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
#endif
internal bool TryRead(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options, ref ReadStack state, out T? value)
{
if (ConverterStrategy == ConverterStrategy.Value)
Expand Down Expand Up @@ -320,9 +317,6 @@ internal override sealed bool TryReadAsObject(ref Utf8JsonReader reader, JsonSer
/// </summary>
private static bool IsNull(T value) => value is null;

#if NET6_0_OR_GREATER
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
#endif
internal bool TryWrite(Utf8JsonWriter writer, in T value, JsonSerializerOptions options, ref WriteStack state)
{
if (writer.CurrentDepth >= options.EffectiveMaxDepth)
Expand Down