Skip to content

[release/6.0-rc1] Migrate LoggerMessageGenerator to IIncrementalGenerator #58271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anipik merged 3 commits into from
Aug 28, 2021
Merged

[release/6.0-rc1] Migrate LoggerMessageGenerator to IIncrementalGenerator #58271

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1371a66
Migrate LoggerMessageGenerator to IIncrementalGenerator
eerhardt Aug 24, 2021
103e883
PR feedback
eerhardt Aug 24, 2021
630ed44
PR feedback
eerhardt Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
PR feedback
  • Loading branch information
@eerhardt
eerhardt authored and github-actions committed Aug 27, 2021
commit 630ed4447136495adb799c554202e2d931335e68
3 changes: 1 addition & 2 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ internal static bool IsSyntaxTargetForGeneration(SyntaxNode node) =>

foreach (AttributeListSyntax attributeListSyntax in methodDeclarationSyntax.AttributeLists)
{
foreach (var attributeSyntax in attributeListSyntax.Attributes)
foreach (AttributeSyntax attributeSyntax in attributeListSyntax.Attributes)
{
IMethodSymbol attributeSymbol = context.SemanticModel.GetSymbolInfo(attributeSyntax).Symbol as IMethodSymbol;
if (attributeSymbol == null)
Expand All @@ -55,7 +55,6 @@ internal static bool IsSyntaxTargetForGeneration(SyntaxNode node) =>
return methodDeclarationSyntax.Parent as ClassDeclarationSyntax;
}
}

}

return null;
Expand Down