[release/6.0] Fix detection of unsupported links #58399
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-io |
|
Approved for release/6.0 : localized bug fix, self evidently incorrect, to a new API. |
|
Pending leg (Build OSX x64 Debug AllSubsets_Mono_LLVMAOT) shows the following error in dev.azure:
@danmoseley all other legs already finished, can we merge? |
|
I clicked rerun as there's no harm and I can merge tomorrow. |
|
@dotnet/dnceng what do you make of this:
|
This is one-to-two-years-ago's version of a long term persistent challenge with Azure DevOps. Basically, a hosted macOS agent started your job, and somewhere after starting the build step that has no logs (but absolutely any time from 0s to all the time) died completely... some kind of sudden catastrophic crash of the agent process, hang or destruction of the virtual machine it's running on, who knows. In recent times, the incidence has been such a low percentage that we're not actively pursuing the matter, but it's known to never be a statistic with 0% failure, since the build itself could choose to rapidly eat all the memory/disk space, or even accidentally kill or impact the agent process on the agent, leading to the termination. If that changes (like if we see enough of these to be as big of a problem as the package feed issue has been), we should raise the matter via the typical manner (ping dnceng, get FR team to make an IcM with the Hosted Mac folks). |
|
Couldn't figure out how to stop the zombie OSX job so rerunning it all. |
|
A few random test jobs failed on tvOSSimulator. None of them IO tests, all simliar to anothre PR right now where we discussed them. Merging. |
Backport of #58391 to release/6.0
/cc @jozkee
Customer Impact
Guarding condition in
ResolveLinkTarget(returnFinalTarget:true)was wrong and was letting unsupported reparse points (e.g: AppExecLinks) to slip through and throw an exception whileResolveLinkTarget(returnFinalTarget:false)was correctly returningnull.Testing
Added offending scenario and assert that both code paths return correctly in such case.
Risk
Low but this was an overlook of #57996.