Skip to content

Add Zero property to Quaternion. #58406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 9 commits into from
Sep 1, 2021
Merged

Add Zero property to Quaternion. #58406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ede0ee9
Add `Zero` and `IsZero` properties to `Quaternion`.
Takym Aug 13, 2021
1829b95
Added test codes for Quaternion.Zero and IsZero.
Takym Aug 17, 2021
c931006
Merge branch 'dotnet:main' into Quaternion
Takym Aug 17, 2021
7a54468
Update the reference assembly for Quaternion.
Takym Aug 17, 2021
fa587ff
Remove the `Quaternion.IsZero` property.
Takym Aug 17, 2021
316bc1e
Quaternion.Zero, change `default` to `new()`
Takym Sep 1, 2021
afec383
Merge branch 'Quaternion' into Quaternion2
Takym Sep 1, 2021
274db04
Update src/libraries/System.Private.CoreLib/src/System/Numerics/Quate…
Takym Sep 1, 2021
e19e94b
Update QuaternionTests.cs
Takym Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ public partial struct Quaternion : System.IEquatable<System.Numerics.Quaternion>
public float Z;
public Quaternion(System.Numerics.Vector3 vectorPart, float scalarPart) { throw null; }
public Quaternion(float x, float y, float z, float w) { throw null; }
public static System.Numerics.Quaternion Zero { get { throw null; } }
Copy link
Member

@danmoseley danmoseley Aug 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please generate this file? that will make it ordered, so next time we generate there won't be extra diffs. info:

runtime/docs/coding-guidelines/updating-ref-source.md

Line 16 in 57bfe47

1) Run `dotnet build --no-incremental /t:GenerateReferenceSource` from the System.Runtime/src directory.

public static System.Numerics.Quaternion Identity { get { throw null; } }
public readonly bool IsIdentity { get { throw null; } }
public static System.Numerics.Quaternion Add(System.Numerics.Quaternion value1, System.Numerics.Quaternion value2) { throw null; }
Expand Down
14 changes: 14 additions & 0 deletions src/libraries/System.Numerics.Vectors/tests/QuaternionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,6 +878,20 @@ public void QuaternionEqualsTest1()
Assert.Equal(expected, actual);
}

// A test for Zero
[Fact]
public void QuaternionZeroTest()
{
// A default value should be equal to a zero value.
Assert.Equal(default(Quaternion), Quaternion.Zero);

// A newly constructed value should be equal to a zero value.
Assert.Equal(new Quaternion(), Quaternion.Zero);

// A newly constructed value with (0, 0, 0, 0) should be equal to a zero value.
Assert.Equal(new Quaternion(0, 0, 0, 0), Quaternion.Zero);
}

// A test for Identity
[Fact]
public void QuaternionIdentityTest()
Expand Down
7 changes: 7 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/Numerics/Quaternion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@ public Quaternion(Vector3 vectorPart, float scalarPart)
W = scalarPart;
}

/// <summary>Gets a quaternion that represents a zero.</summary>
/// <value>A quaternion whose values are <c>(0, 0, 0, 0)</c>.</value>
public static Quaternion Zero
{
get => default;
}

/// <summary>Gets a quaternion that represents no rotation.</summary>
/// <value>A quaternion whose values are <c>(0, 0, 0, 1)</c>.</value>
public static Quaternion Identity
Expand Down