[release/5.0] Notify Reference Tracker runtime of disconnect at the right time #58412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on misunderstanding of SyncBlock clean-up modes the indication of when an Native Object Wrapper was being collected was being done after the wrapper's Finalizer was run. However, this information must be conveyed prior to wrapper finalization and synchronously during the GC.
AaronRobinsonMSFT
added
Servicing-consider
jeffschwMSFT
approved these changes
Aug 31, 2021
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. Please get a code review and we can take for consideration for 5.0.x.
jkoritzinsky
approved these changes
Aug 31, 2021
elinor-fung
approved these changes
Aug 31, 2021
Member
elinor-fung
left a comment
elinor-fung
left a comment
There was a problem hiding this comment.
My comments are minor things for when this goes to 7.0 - not so much for 5.0
src/tests/Interop/COM/ComWrappers/MockReferenceTrackerRuntime/ReferenceTrackerRuntime.cpp
Outdated
Show resolved
Hide resolved
Member
Author
There is no .NET 7 PR yet, but I will fold this feedback into that when it is opened. |
AaronRobinsonMSFT
changed the title
leecow
added
Servicing-approved
AaronRobinsonMSFT
changed the title
Contributor
|
Is there a reason this was scheduled for 5.0.11 and not the next update? I guess 5.0.11 could be roughly expected in the middle of October, right? |
Member
Author
|
@Marv51 Yes, this is for the October update. Unfortunately we missed the 5.0.10 release snap so this was pushed to the next service release. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/CsWinRT#840
Customer Impact
Based on misunderstanding of SyncBlock clean-up modes the indication of when an Native Object Wrapper was being collected was being done after the wrapper's Finalizer was run. However, this information must be conveyed prior to wrapper finalization and synchronously during the GC. See
IReferenceTracker::DisconnectFromTrackerSource.Workaround
There are no workarounds for this issue.
Testing
Added a tests. Have provided private binaries to C#/WinRT team for validation.
Risk
Minimal. .NET 5 is the first release of
ComWrappersand this issue only impacts WinRT scenarios./cc @davidwrighton @jkoritzinsky @elinor-fung