Skip to content

Support unseekable filestream when ReadAllBytes[Async] #58434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 9 commits into from
Oct 13, 2021
Merged

Support unseekable filestream when ReadAllBytes[Async] #58434

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b269ffe
lateapexearlyspeed-issue-58383 Support unseekable filestream when Rea…
lateapexearlyspeed Aug 31, 2021
c50ab3d
issue-58383 Refine code; Add test cases.
lateapexearlyspeed Sep 10, 2021
d4cf11e
the docs were wrong, offsets are not ignored for non-seekable files
adamsitnik Sep 13, 2021
94ba70a
Merge remote-tracking branch 'upstream/main' into lateapexearlyspeed-…
adamsitnik Sep 13, 2021
b47fd7f
issue-58383 Fix comment: add linux side test cases.
lateapexearlyspeed Sep 29, 2021
e98fb15
issue-58383 Check /dev/tty existence before running test.
lateapexearlyspeed Sep 29, 2021
cdd7700
Merge branch 'main' into lateapexearlyspeed-issue-58383-SupportUnSeek…
adamsitnik Oct 13, 2021
b0f8adb
improve the tests
adamsitnik Oct 13, 2021
b741120
mkfifo is not available for Browser
adamsitnik Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lateapexearlyspeed-issue-58383 Support unseekable filestream when Rea… 
…dAllBytes[Async].
  • Loading branch information
@lateapexearlyspeed
lateapexearlyspeed committed Aug 31, 2021
commit b269ffeb5a1f21166c362a3d22a230157e8a375a
11 changes: 11 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/IO/File.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,11 @@ public static byte[] ReadAllBytes(string path)
// bufferSize == 1 used to avoid unnecessary buffer in FileStream
using (FileStream fs = new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.Read, bufferSize: 1, FileOptions.SequentialScan))
{
if (!fs.CanSeek)
{
return ReadAllBytesUnknownLength(fs);
}

long fileLength = fs.Length;
if (fileLength > int.MaxValue)
{
Expand Down Expand Up @@ -729,6 +734,12 @@ private static async Task<string> InternalReadAllTextAsync(string path, Encoding
bool returningInternalTask = false;
try
{
if (!fs.CanSeek)
{
returningInternalTask = true;
return InternalReadAllBytesUnknownLengthAsync(fs, cancellationToken);
}

long fileLength = fs.Length;
if (fileLength > int.MaxValue)
{
Expand Down