Skip to content

Follow up on Scatter/Gather API changes #58447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 9 commits into from
Oct 14, 2021
Merged

Follow up on Scatter/Gather API changes #58447

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e502084
Allocate an array of memory handles only if needed.
teo-tsirpanis Aug 31, 2021
3f80275
Remove an unnecessary variable in the multiple-syscall write gather.
teo-tsirpanis Aug 31, 2021
6e0836b
Actually verify the content read by the read scatter operation.
teo-tsirpanis Aug 31, 2021
e95d021
Use AssertExtensions.SequenceEqual.
teo-tsirpanis Aug 31, 2021
8177b23
Delay allocating native memory.
teo-tsirpanis Aug 31, 2021
1450290
Verify that the whole file was read in the scatter/gather test.
teo-tsirpanis Aug 31, 2021
1c74cdf
Test the case when the scatter/gather buffers are acceptable by the W…
teo-tsirpanis Aug 31, 2021
4625c16
Avoid null pointer dereferences when passing an empty segment array.
teo-tsirpanis Sep 13, 2021
0c0f64e
Test performing scatter/gather I/O with an empty segment array.
teo-tsirpanis Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Test performing scatter/gather I/O with an empty segment array.
  • Loading branch information
@teo-tsirpanis
teo-tsirpanis committed Sep 13, 2021
commit 0c0f64edfcd6918f2c74462314aee2d26a42c71d
11 changes: 11 additions & 0 deletions src/libraries/System.IO.FileSystem/tests/RandomAccess/NoBuffering.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,17 @@ public async Task ReadWriteAsyncUsingMultipleBuffers(bool memoryPageSized)
}
}

[Fact]
public async Task ReadWriteAsyncUsingEmptyBuffers()
{
string filePath = GetTestFilePath();
using SafeFileHandle handle = File.OpenHandle(filePath, FileMode.CreateNew, FileAccess.ReadWrite, FileShare.None, FileOptions.Asynchronous | NoBuffering);

long nRead = await RandomAccess.ReadAsync(handle, Array.Empty<Memory<byte>>(), 0);
Assert.Equal(0, nRead);
await RandomAccess.WriteAsync(handle, Array.Empty<ReadOnlyMemory<byte>>(), 0);
}

// when using FileOptions.Asynchronous we are testing Scatter&Gather APIs on Windows (FILE_FLAG_OVERLAPPED requirement)
private static FileOptions GetFileOptions(bool asyncHandle) => (asyncHandle ? FileOptions.Asynchronous : FileOptions.None) | NoBuffering;
}
Expand Down