[Main] Don't always build source build with ci flag #58497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building portable, only a subset of runtime needs to be built. allconfigurations is only needed in a non-portable build.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
FWIW, as long as you don't edit a code line in the same or neighboring line as another change you won't cause a merge conflict. |
ViktorHofer
approved these changes
Sep 1, 2021
Member
Author
I did this because I am editing a neighboring line. |
Member
Omg disregard, I didn't see the adjacent one. |
dseefeld
approved these changes
Sep 1, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local dev builds should not normally be building source-build with the "ci" flag. The official builds/ci will set this appropriately. This change removes the "ci" flags for source-build.
This is porting #58457 to main.
I based this PR on #58493 to avoid merge conflicts.