Skip to content

[Libraries] Fix TimeZoneInfoTests IsIanaIdTest for iOS/MacCatalyst/tvOS #58562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marek-safar merged 7 commits into from
Sep 6, 2021
Merged

[Libraries] Fix TimeZoneInfoTests IsIanaIdTest for iOS/MacCatalyst/tvOS #58562

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d7ee4e7
[Libraries] Fix TimeZoneInfoTests IsIanaIdTest for iOS/MacCatalyst/tvOS
Sep 2, 2021
4aa8873
[Libraries] Fix IsIanaIdTest to assert throw for iOS/MacCatalyst/tvOS
Sep 2, 2021
471ddd9
Readd new line
Sep 2, 2021
a7c9291
[Mobile][Libraries] System.Runtime.Tests TimeZoneInfoTests remove mob…
Sep 3, 2021
694989e
[libraries] System.Runtime.Tests revert IsIanaIdTest iOS tvOS special…
Sep 3, 2021
20a55b7
Merge remote-tracking branch 'upstream/main' into fix_IsIanaId_iOS_ma…
Sep 3, 2021
67039ab
Remove active issue added in recently merged PR
Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Libraries] Fix TimeZoneInfoTests IsIanaIdTest for iOS/MacCatalyst/tvOS
  • Loading branch information
Mitchell Hwang committed Sep 2, 2021
commit d7ee4e7d75556e9c0896da527b1d586992cd41a1
2 changes: 1 addition & 1 deletion src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2664,7 +2664,7 @@ public static void IsIanaIdTest()
{
bool expected = !s_isWindows;

Assert.Equal((expected || TimeZoneInfo.Local.Id.Equals("Utc", StringComparison.OrdinalIgnoreCase)), TimeZoneInfo.Local.HasIanaId);
Assert.Equal((expected || PlatformDetection.IsiOS || PlatformDetection.IstvOS || TimeZoneInfo.Local.Id.Equals("Utc", StringComparison.OrdinalIgnoreCase)), TimeZoneInfo.Local.HasIanaId);
Copy link
Member

@filipnavara filipnavara Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't make sense to me. I'd assume that !s_isWindows is true thus expected == true and this condition would not need the change.

Copy link
Member Author

@mdh1418 mdh1418 Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah oops, I got the order wrong when I checked the failure


foreach (TimeZoneInfo tzi in TimeZoneInfo.GetSystemTimeZones())
{
Expand Down