Skip to content

[main] Conditionally pack symbols based on keepNativeSymbols #58577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anipik merged 3 commits into from
Sep 3, 2021
Merged

[main] Conditionally pack symbols based on keepNativeSymbols #58577

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb73a38
Conditionally pack symbols based on keepNativeSymbols
MichaelSimons Sep 2, 2021
9065db0
Fix casing issue
MichaelSimons Sep 2, 2021
875ece3
Add clarifing comment
MichaelSimons Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Conditionally pack symbols based on keepNativeSymbols
  • Loading branch information
@MichaelSimons
MichaelSimons authored and github-actions committed Sep 2, 2021
commit bb73a3876a1bf5d8538482f840c8c7b5b03d9c85
2 changes: 1 addition & 1 deletion src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<DebugType>none</DebugType>
<IsPackable>true</IsPackable>
<AllowedOutputExtensionsInSymbolsPackageBuildOutputFolder>$(SymbolsSuffix)</AllowedOutputExtensionsInSymbolsPackageBuildOutputFolder>
<TargetsForTfmSpecificDebugSymbolsInPackage>$(TargetsForTfmSpecificDebugSymbolsInPackage);AddRuntimeSpecificNativeSymbolToPackage</TargetsForTfmSpecificDebugSymbolsInPackage>
<TargetsForTfmSpecificDebugSymbolsInPackage Condition="'$(keepNativeSymbols)' != 'true'">$(TargetsForTfmSpecificDebugSymbolsInPackage);AddRuntimeSpecificNativeSymbolToPackage</TargetsForTfmSpecificDebugSymbolsInPackage>
<UseRuntimePackageDisclaimer>true</UseRuntimePackageDisclaimer>
<!-- This is a native package and doesn't contain any ref/lib assets. -->
<NoWarn>$(NoWarn);NU5128</NoWarn>
Expand Down