Skip to content

Undo struct promotion on "RetInd" code path #58582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunalspathak merged 9 commits into from
Sep 3, 2021
Merged

Undo struct promotion on "RetInd" code path #58582

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9ef80ba
TOREVERT: small repro case
kunalspathak Aug 30, 2021
577020d
Fix the undone struct promotion for return
kunalspathak Sep 2, 2021
03f0db1
Display lclVar number
kunalspathak Sep 2, 2021
961aced
Revert "TOREVERT: small repro case"
kunalspathak Sep 2, 2021
32632ce
Add test case
kunalspathak Sep 2, 2021
90ac6eb
jit format
kunalspathak Sep 2, 2021
67fed19
Combine the condition
kunalspathak Sep 2, 2021
af3faa2
Add an assert to catch the missing places
kunalspathak Sep 2, 2021
1fe3bdc
Remove unneeded variable setting from csproj
kunalspathak Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
jit format
  • Loading branch information
@kunalspathak
kunalspathak committed Sep 2, 2021
commit 90ac6ebe5ef02580f083db1f5000141ca0fe440b
2 changes: 1 addition & 1 deletion src/coreclr/jit/morph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13867,7 +13867,7 @@ GenTree* Compiler::fgMorphRetInd(GenTreeUnOp* ret)
if (fgGlobalMorph)
{
// If struct promotion was undone, adjust the annotations
if(fgMorphImplicitByRefArgs(addr))
if (fgMorphImplicitByRefArgs(addr))
{
return ind;
}
Expand Down