Skip to content

Add cast when replacing promoted struct with field in lowering #58589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 7 commits into from
Sep 10, 2021
Merged

Add cast when replacing promoted struct with field in lowering #58589

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
960be87
Add cast when replacing promoted struct with field in lowering
jakobbotsch Sep 2, 2021
aabdb12
Add test
jakobbotsch Sep 2, 2021
7a55f1e
Fix formatting
jakobbotsch Sep 2, 2021
48c8474
Fix test cases
jakobbotsch Sep 3, 2021
5ce3a0f
Type returned-struct-as-primitive correctly for normalization
jakobbotsch Sep 9, 2021
72d0c9d
Fix assertion
jakobbotsch Sep 9, 2021
5250719
Run jit-format
jakobbotsch Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Run jit-format
  • Loading branch information
@jakobbotsch
jakobbotsch committed Sep 9, 2021
commit 525071956a735015eaf74686971a5d991727a575
3 changes: 2 additions & 1 deletion src/coreclr/jit/lower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3440,7 +3440,8 @@ void Lowering::LowerRetSingleRegStructLclVar(GenTreeUnOp* ret)
// We are returning as a primitive type and the lcl is of struct type.
assert(comp->info.compRetNativeType != TYP_STRUCT);
assert((genTypeSize(comp->info.compRetNativeType) == genTypeSize(ret)) ||
(varTypeIsIntegral(ret) && varTypeIsIntegral(comp->info.compRetNativeType) && (genTypeSize(comp->info.compRetNativeType) <= genTypeSize(ret))));
(varTypeIsIntegral(ret) && varTypeIsIntegral(comp->info.compRetNativeType) &&
(genTypeSize(comp->info.compRetNativeType) <= genTypeSize(ret))));
// If the actual return type requires normalization, then make sure we
// do so by using the correct small type for the GT_LCL_FLD. It would
// be conservative to check just compRetNativeType for this since small
Expand Down