Skip to content

add TLS 1.3 support to WinHttp #58590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wfurt merged 4 commits into from
Sep 4, 2021
Merged

add TLS 1.3 support to WinHttp #58590

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bbe732
add TLS 1.3 support to WinHttp
wfurt Sep 2, 2021
76277bb
remove extra line
wfurt Sep 2, 2021
0ce2c48
fix comment
wfurt Sep 2, 2021
5e33673
add check if WINHTTP_FLAG_SECURE_PROTOCOL_TLS1_3 is supported
wfurt Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix comment
  • Loading branch information
@wfurt
wfurt committed Sep 2, 2021
commit 0ce2c487fc17e0d9266e026bd6a0cd7ae9619bc2
5 changes: 1 addition & 4 deletions src/libraries/System.Net.Http.WinHttpHandler/src/System/Net/Http/WinHttpHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,10 +1193,7 @@ private void SetSessionHandleTlsOptions(SafeWinHttpHandle sessionHandle)
optionData |= Interop.WinHttp.WINHTTP_FLAG_SECURE_PROTOCOL_TLS1_3;
}

// As of Win10RS5 there's no public constant for WinHTTP + TLS 1.3
// This library builds against netstandard, which doesn't define the Tls13 enum field.

// If only unknown values (e.g. TLS 1.3) were asked for, report ERROR_INVALID_PARAMETER.
// If only unknown values were asked for, report ERROR_INVALID_PARAMETER.
if (optionData == 0)
{
throw WinHttpException.CreateExceptionUsingError(
Expand Down