Skip to content

Use arcade power source build infra #58651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anipik merged 3 commits into from
Sep 14, 2021
Merged

Use arcade power source build infra #58651

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
329bbf5
add yml files
Sep 10, 2021
6143407
add file version and condition package reference on source build
Sep 10, 2021
d948056
to avoid copying the file from the cache
Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
to avoid copying the file from the cache
  • Loading branch information
Anirudh Agnihotry committed Sep 13, 2021
commit d9480564e1e08c25f464f08a4cb604ca5d9136ed
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Quic/src/System.Net.Quic.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@

<!-- Support for deploying msquic -->
<ItemGroup Condition="'$(TargetsWindows)' == 'true' and
('$(TargetArchitecture)' == 'x64' or '$(TargetArchitecture)' == 'x86')">
('$(TargetArchitecture)' == 'x64' or '$(TargetArchitecture)' == 'x86') and '$(DotNetBuildFromSource)' != 'true'">
<BinPlaceDir Include="$(MicrosoftNetCoreAppRuntimePackNativeDir)" ItemName="NativeBinPlaceItem" />
Copy link
Member

@ericstj ericstj Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but something to consider moving forward is that this fails silently if that quic package changes it's shape. It might be good to avoid a wildcard here. We should be explicit about things which we end up shipping in the shared framework.

<BinPlaceDir Include="$(NetCoreAppCurrentTestHostSharedFrameworkPath)" ItemName="NativeBinPlaceItem" />
<BinPlaceDir Include="$(NetCoreAppCurrentRuntimePath)" ItemName="NativeBinPlaceItem" />
Expand Down