Skip to content

[release/6.0] add TLS 1.3 support to WinHttp #58718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 4 commits into from
Sep 7, 2021
Merged

[release/6.0] add TLS 1.3 support to WinHttp #58718

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd902c5
add TLS 1.3 support to WinHttp
wfurt Sep 2, 2021
52aa07e
remove extra line
wfurt Sep 2, 2021
b1b20d0
fix comment
wfurt Sep 2, 2021
c213cae
add check if WINHTTP_FLAG_SECURE_PROTOCOL_TLS1_3 is supported
wfurt Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix comment
  • Loading branch information
@wfurt
wfurt authored and github-actions committed Sep 6, 2021
commit b1b20d0d270186793641c3cf83399e40ba6688c5
5 changes: 1 addition & 4 deletions src/libraries/System.Net.Http.WinHttpHandler/src/System/Net/Http/WinHttpHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,10 +1190,7 @@ private void SetSessionHandleTlsOptions(SafeWinHttpHandle sessionHandle)
optionData |= Interop.WinHttp.WINHTTP_FLAG_SECURE_PROTOCOL_TLS1_3;
}

// As of Win10RS5 there's no public constant for WinHTTP + TLS 1.3
// This library builds against netstandard, which doesn't define the Tls13 enum field.

// If only unknown values (e.g. TLS 1.3) were asked for, report ERROR_INVALID_PARAMETER.
// If only unknown values were asked for, report ERROR_INVALID_PARAMETER.
if (optionData == 0)
{
throw WinHttpException.CreateExceptionUsingError(
Expand Down