Skip to content

Add crossgen2 runs for x86 (#58053) #58892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffschwMSFT merged 1 commit into from
Sep 10, 2021
Merged

Add crossgen2 runs for x86 (#58053) #58892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion eng/pipelines/coreclr/perf_slow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,5 +195,37 @@ jobs:
projectFile: microbenchmarks.proj
runKind: micro
runJobTemplate: /eng/pipelines/coreclr/templates/run-performance-job.yml
logicalmachine: 'perfsurf'
logicalmachine: 'perfsurf'

# Uncomment once we fix https://github.com/dotnet/performance/issues/1950
# # run coreclr linux crossgen perf job
# - template: /eng/pipelines/common/platform-matrix.yml
# parameters:
# jobTemplate: /eng/pipelines/coreclr/templates/perf-job.yml
# buildConfig: release
# runtimeFlavor: coreclr
# platforms:
# - Linux_arm64
# jobParameters:
# testGroup: perf
# liveLibrariesBuildConfig: Release
# projectFile: crossgen_perf.proj
# runKind: crossgen_scenarios
# runJobTemplate: /eng/pipelines/coreclr/templates/run-scenarios-job.yml
# logicalmachine: 'perfa64'

# # run coreclr windows crossgen perf job
# - template: /eng/pipelines/common/platform-matrix.yml
# parameters:
# jobTemplate: /eng/pipelines/coreclr/templates/perf-job.yml
# buildConfig: release
# runtimeFlavor: coreclr
# platforms:
# - windows_arm64
# jobParameters:
# testGroup: perf
# liveLibrariesBuildConfig: Release
# projectFile: crossgen_perf.proj
# runKind: crossgen_scenarios
# runJobTemplate: /eng/pipelines/coreclr/templates/run-scenarios-job.yml
# logicalmachine: 'perfsurf'
10 changes: 5 additions & 5 deletions eng/testing/performance/crossgen_perf.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
</ItemGroup>

<ItemGroup>
<Crossgen2SizeOnDiskWorkItem Include="@(SingleAssembly)" Condition="'$(Architecture)' == 'x64'">
<Crossgen2SizeOnDiskWorkItem Include="@(SingleAssembly)">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<PreCommands>$(Python) $(Crossgen2Directory)pre.py crossgen2 --core-root $(CoreRoot) --single %(Identity) </PreCommands>
<Command>$(Python) $(Crossgen2Directory)test.py sod --scenario-name &quot;Crossgen2 %(Identity) Size&quot; --dirs ./crossgen.out/</Command>
Expand All @@ -69,18 +69,18 @@

<ItemGroup>
<!-- Enable crossgen2 tests on Windows x64 and Linux x64 -->
<HelixWorkItem Include="@(Crossgen2WorkItem -> 'Crossgen2 %(Identity)')" Condition="'$(Architecture)' == 'x64'">
<HelixWorkItem Include="@(Crossgen2WorkItem -> 'Crossgen2 %(Identity)')">
<Timeout>4:00</Timeout>
</HelixWorkItem>
<HelixWorkItem Include="@(Crossgen2SingleThreadedWorkItem -> 'Crossgen2 single-threaded %(Identity)')" Condition="'$(Architecture)' == 'x64'">
<HelixWorkItem Include="@(Crossgen2SingleThreadedWorkItem -> 'Crossgen2 single-threaded %(Identity)')">
<Timeout>4:00</Timeout>
</HelixWorkItem>
<HelixWorkItem Include="Crossgen2 Composite Framework R2R" Condition="'$(Architecture)' == 'x64'">
<HelixWorkItem Include="Crossgen2 Composite Framework R2R">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<Command>$(Python) $(Crossgen2Directory)test.py crossgen2 --core-root $(CoreRoot) --composite $(Crossgen2Directory)framework-r2r.dll.rsp</Command>
<Timeout>1:00</Timeout>
</HelixWorkItem>
<HelixWorkItem Include="@(Crossgen2SizeOnDiskWorkItem -> 'Crossgen2 Size on Disk %(Identity)')" Condition="'$(Architecture)' == 'x64'">
<HelixWorkItem Include="@(Crossgen2SizeOnDiskWorkItem -> 'Crossgen2 Size on Disk %(Identity)')">
<Timeout>4:00</Timeout>
</HelixWorkItem>
</ItemGroup>
Expand Down