Skip to content

Conversation

@omajid
Copy link
Member

@omajid omajid commented Sep 9, 2021

Instead, use the runtime's normal detection logic to decide what to do.

Backport of #58641 to release/6.0.

See: dotnet/source-build#2408

Instead, use the runtime's normal detection logic to decide what to do.

Backport of dotnet#58641 to release/6.0.

See: dotnet/source-build#2408
@ghost
Copy link

ghost commented Sep 9, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 9, 2021
@ghost
Copy link

ghost commented Sep 10, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Instead, use the runtime's normal detection logic to decide what to do.

Backport of #58641 to release/6.0.

See: dotnet/source-build#2408

Author: omajid
Assignees: -
Labels:

area-Infrastructure, community-contribution

Milestone: -

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Anipik
Copy link
Contributor

Anipik commented Sep 13, 2021

cc @jeffschwMSFT

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@jeffschwMSFT jeffschwMSFT merged commit b9f273a into dotnet:release/6.0 Sep 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants