Skip to content

Conversation

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Sep 10, 2021

This allows consuming the dotnet host that was just built instead of relying on a downloaded one (which doesn't exist for s390x).
We need to move the host subset build before the libs subset so that the artifacts are available before externals.csproj runs.

This allows consuming the dotnet host that was just built instead of relying on a downloaded one.
We need to move the `host` subset build before the `libs` subset so that the artifacts are available before externals.csproj runs.
@ghost
Copy link

ghost commented Sep 10, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This allows consuming the dotnet host that was just built instead of relying on a downloaded one.
We need to move the host subset build before the libs subset so that the artifacts are available before externals.csproj runs.

Author: akoeplinger
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@akoeplinger
Copy link
Member Author

@ViktorHofer let me know if this makes sense, especially the subsets move.

@jkoritzinsky
Copy link
Member

cc: @agocke

@am11
Copy link
Member

am11 commented Sep 10, 2021

Nice! I thought it is not possible to use live host due to some bindings with SDK (e.g. host changes API that goes hand-in-hand with the SDK), which is why we wait for the whole update cycle: runtime->sdk->{installer,arcade}->runtime.
If it is not the case then why limit it to just s390x; all platforms can take advantage of live host, no?

@directhex directhex marked this pull request as ready for review September 20, 2021 14:28
@akoeplinger
Copy link
Member Author

If it is not the case then why limit it to just s390x; all platforms can take advantage of live host, no?

My understanding is that the main reason for the current setup is so you don't need to have the native toolchain/compilers to build the corehost if you just want to work on the managed libraries and run tests.

@jkoritzinsky
Copy link
Member

The current issue is more with how we split up our CI pipeline. Right now we build the hosts after the libraries because the host tests require the libraries tests (and because that's how it worked before repo consolidation).

@ViktorHofer
Copy link
Member

What Jeremy said makes sense but it's also what Alex says. Currently libraries devs are able to just build the libs subset. When building the live host that wouldn't be possible anymore with the current loosely defined dependency. We would want to establish a dependency from the libs test execution to the host.

@akoeplinger
Copy link
Member Author

Please let me know if there's anything missing here or if you don't agree with this approach :)

@akoeplinger akoeplinger merged commit cab3a63 into dotnet:main Oct 5, 2021
@akoeplinger akoeplinger deleted the livebuilt-corehost branch October 5, 2021 15:58
@akoeplinger
Copy link
Member Author

FYI @uweigand @nealef

@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants