Skip to content

[release/6.0] [mono] Update attribute name used for controlling frame pointer elimination #59091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marek-safar merged 1 commit into from
Sep 15, 2021
Merged

[release/6.0] [mono] Update attribute name used for controlling frame pointer elimination #59091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[mono] Update attribute name used for controlling frame pointer elimi… 
…nation

LLVM 8 introduced `"frame-pointer"="all"` as a substitute for
`"no-frame-pointer-elim"="true"`. LLVM 10 outright removed
`"no-frame-pointer-elim"`.
  • Loading branch information
@imhameed
imhameed authored and github-actions committed Sep 14, 2021
commit 1e193aca69c2b3453b68c192e6d6edf9133f86d5
2 changes: 1 addition & 1 deletion src/mono/mono/mini/mini-llvm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11473,7 +11473,7 @@ emit_method_inner (EmitContext *ctx)
mono_llvm_add_func_attr (method, LLVM_ATTR_UW_TABLE);

if (cfg->disable_omit_fp)
mono_llvm_add_func_attr_nv (method, "no-frame-pointer-elim", "true");
mono_llvm_add_func_attr_nv (method, "frame-pointer", "all");

if (cfg->compile_aot) {
if (mono_aot_is_externally_callable (cfg->method)) {
Expand Down