Skip to content

[release/6.0] Emit diagnostics & exceptions for sourcegen handling init-only properties & JsonInclude attributes #59097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anipik merged 4 commits into from
Sep 15, 2021
Merged

[release/6.0] Emit diagnostics & exceptions for sourcegen handling init-only properties & JsonInclude attributes #59097

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46aaf43
Emit diagnostic warnings and exceptions when sourcegen is handling in…
eiriktsarpalis Sep 11, 2021
091fc6e
add localizations for runtime exception messages
eiriktsarpalis Sep 11, 2021
1318125
remove exception messages from resource strings
eiriktsarpalis Sep 14, 2021
ad0e10b
fix alphabetical ordering
eiriktsarpalis Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix alphabetical ordering
  • Loading branch information
@eiriktsarpalis
eiriktsarpalis committed Sep 15, 2021
commit ad0e10b22237d2c3edeaa678ea8386e9c684a1c4
2 changes: 1 addition & 1 deletion src/libraries/System.Text.Json/gen/System.Text.Json.SourceGeneration.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@
<Compile Include="$(CommonPath)\Roslyn\GetBestTypeByMetadataName.cs" Link="Common\Roslyn\GetBestTypeByMetadataName.cs" />
<Compile Include="ClassType.cs" />
<Compile Include="CollectionType.cs" />
<Compile Include="JsonSourceGenerator.Emitter.ExceptionMessages.cs" />
<Compile Include="JsonConstants.cs" />
<Compile Include="JsonSourceGenerator.Emitter.cs" />
<Compile Include="JsonSourceGenerator.Emitter.ExceptionMessages.cs" />
<Compile Include="JsonSourceGenerator.Parser.cs" />
<Compile Include="ObjectConstructionStrategy.cs" />
<Compile Include="ParameterGenerationSpec.cs" />
Expand Down