[interp] Disable optimization if the var index is greater than G_MAXUINT16 #59225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…INT16 We store the var index in the guint16 slots of the instruction
ghost
added
the
|
Tagging subscribers to this area: @BrzVlad Issue DetailsWe store the var index in the guint16 slots of the instruction
|
Member
Author
|
Methods with more than 64k interp vars are potentially broken since #52242. While this case is probably unlikely, since only certain code structure can trigger the issue, I think we might want to backport to 6.0 since it is a regression and the fix is trivial. |
vargaz
approved these changes
Sep 16, 2021
Member
|
/backport to release/6.0-rc2 |
Contributor
|
Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1245563875 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store the var index in the guint16 slots of the instruction