[release/6.0-rc2] [MonoVM] Reduce P/Invoke GC transition asserts in release builds #59269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
lambdageek and
vargaz
as code owners
|
Tagging subscribers to this area: Issue DetailsBackport of #59029 to release/6.0-rc2 Customer ImpactTestingRisk
|
lambdageek
approved these changes
Sep 21, 2021
jamshedd
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59029 to release/6.0-rc2
/cc @lambdageek @filipnavara
Customer Impact
iOS and Android applications that perform a lot of P/Invokes in a short period of time may have a slower startup time compared to mono/mono-based Xamarin.iOS and Xamarin.Android. Related to #58939
Testing
Manual testing on microbenchmarks.
Risk
Very low. The change disables some assertions on Release builds that we've never seen triggered in dotnet/runtime Mono.