Skip to content

Fix IParseable/ISpanParseable NumberStyles for Single and Double #59320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nietras wants to merge 1 commit into from
Closed

Fix IParseable/ISpanParseable NumberStyles for Single and Double #59320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/libraries/System.Private.CoreLib/src/System/Double.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,7 +1242,7 @@ static double IParseable<double>.Parse(string s, IFormatProvider? provider)

[RequiresPreviewFeatures]
static bool IParseable<double>.TryParse([NotNullWhen(true)] string? s, IFormatProvider? provider, out double result)
=> TryParse(s, NumberStyles.Integer, provider, out result);
=> TryParse(s, NumberStyles.Float | NumberStyles.AllowThousands, provider, out result);

//
// ISignedNumber
Expand All @@ -1257,11 +1257,11 @@ static bool IParseable<double>.TryParse([NotNullWhen(true)] string? s, IFormatPr

[RequiresPreviewFeatures]
static double ISpanParseable<double>.Parse(ReadOnlySpan<char> s, IFormatProvider? provider)
=> Parse(s, NumberStyles.Integer, provider);
=> Parse(s, NumberStyles.Float | NumberStyles.AllowThousands, provider);

[RequiresPreviewFeatures]
static bool ISpanParseable<double>.TryParse(ReadOnlySpan<char> s, IFormatProvider? provider, out double result)
=> TryParse(s, NumberStyles.Integer, provider, out result);
=> TryParse(s, NumberStyles.Float | NumberStyles.AllowThousands, provider, out result);

//
// ISubtractionOperators
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/System.Private.CoreLib/src/System/Single.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1234,7 +1234,7 @@ static float IParseable<float>.Parse(string s, IFormatProvider? provider)

[RequiresPreviewFeatures]
static bool IParseable<float>.TryParse([NotNullWhen(true)] string? s, IFormatProvider? provider, out float result)
=> TryParse(s, NumberStyles.Integer, provider, out result);
=> TryParse(s, NumberStyles.Float | NumberStyles.AllowThousands, provider, out result);

//
// ISignedNumber
Expand All @@ -1249,11 +1249,11 @@ static bool IParseable<float>.TryParse([NotNullWhen(true)] string? s, IFormatPro

[RequiresPreviewFeatures]
static float ISpanParseable<float>.Parse(ReadOnlySpan<char> s, IFormatProvider? provider)
=> Parse(s, NumberStyles.Integer, provider);
=> Parse(s, NumberStyles.Float | NumberStyles.AllowThousands, provider);

[RequiresPreviewFeatures]
static bool ISpanParseable<float>.TryParse(ReadOnlySpan<char> s, IFormatProvider? provider, out float result)
=> TryParse(s, NumberStyles.Integer, provider, out result);
=> TryParse(s, NumberStyles.Float | NumberStyles.AllowThousands, provider, out result);

//
// ISubtractionOperators
Expand Down