Skip to content

Fix issues where the module index GUID table isn't properly computed #59375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidwrighton merged 2 commits into from
Sep 21, 2021
Merged

Fix issues where the module index GUID table isn't properly computed #59375

davidwrighton merged 2 commits into from
Sep 21, 2021

Conversation

@davidwrighton
Copy link
Member

@davidwrighton davidwrighton commented Sep 20, 2021

  • Since there are two possible places where the module indices must be up to date, ensure that they are finalized before either Node writes its data
  • Ensure that module indices are precomputed when needed from inlinee data
  • This fix is necessary for composite with version bubble scenarios (It is necessary to upgrade Bing to the latest crossgen2 compiler)

@davidwrighton
Fix issues where the module index GUID table isn't properly computed
9adcdb3 
- Since there are two possible places where the module indices must be up to date, ensure that they are finalized before either Node writes its data
- Ensure that module indices are precomputed when needed from inlinee data
@davidwrighton
Copy link
Member Author

davidwrighton commented Sep 20, 2021

/backport to release/6.0-rc2

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2021

Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1255151194

@github-actions github-actions bot mentioned this pull request Sep 20, 2021
Merged
trylek
trylek approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks David for fixing this!

@davidwrighton
Copy link
Member Author

davidwrighton commented Sep 20, 2021

/azp list

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 20, 2021

CI/CD Pipelines for this repository:

@davidwrighton
Copy link
Member Author

davidwrighton commented Sep 20, 2021

/azp run runtime-coreclr crossgen2-composite

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 20, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@davidwrighton
Apparently the InstanceEntryPointTableNode also needs to materialize …
353b1be 
…its signatures when an input bubble is present as well
@davidwrighton davidwrighton merged commit 83e1422 into dotnet:main Sep 21, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
@davidwrighton davidwrighton deleted the fix_composite_with_inputbubble branch April 13, 2023 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@trylek trylek trylek approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

No one assigned

Labels

area-crossgen2-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidwrighton @trylek