Skip to content

Conversation

@thaystg
Copy link
Member

@thaystg thaystg commented Sep 21, 2021

As @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the beginning of this heap everytime that was sending debugger commands.
I think we should backport it to rc2.

@lewing can we backport?

Thanks a lot @pavelsavara

@ghost
Copy link

ghost commented Sep 21, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

As @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the begin of this heap everytime that was sending debugger commands.
I think we should backport it to rc2.

@lewing can we backport?

Thanks a lot @pavelsavara

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@lewing
Copy link
Member

lewing commented Sep 21, 2021

/backport to release/6.0-rc2

@github-actions
Copy link
Contributor

Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1258574584

@thaystg thaystg added Servicing-consider Issue for next servicing release review and removed Servicing-consider Issue for next servicing release review labels Sep 21, 2021
@radical radical added the arch-wasm WebAssembly architecture label Sep 21, 2021
@ghost
Copy link

ghost commented Sep 21, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

As @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the begin of this heap everytime that was sending debugger commands.
I think we should backport it to rc2.

@lewing can we backport?

Thanks a lot @pavelsavara

Author: thaystg
Assignees: -
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@radical
Copy link
Member

radical commented Sep 21, 2021

As @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the begin of this heap everytime that was sending debugger commands.

What did the failure look like?

@thaystg
Copy link
Member Author

thaystg commented Sep 21, 2021

We don't detect any failure, @pavelsavara saw that the code was strange by reading it to refactor.

@thaystg thaystg merged commit 0ea3b7d into dotnet:main Sep 21, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Debugger-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants