-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[wasm][debugger] Fixing memory corruption #59419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @thaystg Issue DetailsAs @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the begin of this heap everytime that was sending debugger commands. @lewing can we backport? Thanks a lot @pavelsavara
|
|
/backport to release/6.0-rc2 |
|
Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1258574584 |
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAs @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the begin of this heap everytime that was sending debugger commands. @lewing can we backport? Thanks a lot @pavelsavara
|
What did the failure look like? |
|
We don't detect any failure, @pavelsavara saw that the code was strange by reading it to refactor. |
As @pavelsavara detected the code that I wrote was corrupting memory on Module.HEAPU8.buffer, it was reusing the beginning of this heap everytime that was sending debugger commands.
I think we should backport it to rc2.
@lewing can we backport?
Thanks a lot @pavelsavara