[wasm][debugger] Reusing buffer to avoid allocate every debugger message #59480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsThis will speed up debugger and experience and will avoid leaking memory.
|
Member
Author
|
@pavelsavara I'll wait for your approval to backport :) |
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis will speed up debugger and experience and will avoid leaking memory.
|
radical
approved these changes
Sep 22, 2021
pavelsavara
approved these changes
Sep 23, 2021
radekdoulik
approved these changes
Sep 23, 2021
Member
Author
|
/backport to release/6.0-rc2 |
Contributor
|
Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1265809313 |
Member
Author
|
@pavelsavara could you please review again, now that it will be merged after your ts changes? |
radical
reviewed
Sep 28, 2021
pavelsavara
reviewed
Sep 28, 2021
pavelsavara
reviewed
Sep 28, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will speed up debugger and experience and will avoid leaking memory.