Skip to content

[release/6.0-rc2][wasm] Fixes, and improvements based on user feedback #59486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
radical wants to merge 17 commits into from
Closed

[release/6.0-rc2][wasm] Fixes, and improvements based on user feedback #59486

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ae21b90
[wasm] Change optimization flag defaults for Debug config
radical Sep 17, 2021
7b75d85
[wasm] EmccCompile: Fix incremental build, in case of only partial
radical Sep 21, 2021
32f9504
Bump sdk for workload testing to 6.0.100-rc.2.21472.15
radical Sep 22, 2021
2984d86
Apply suggestions from code review
radical Sep 22, 2021
67cda93
Don't set optimization defaults for Debug config, when publishing
radical Sep 22, 2021
948b3ce
Merge remote-tracking branch 'origin/release/6.0-rc2' into fixes-rc2
radical Sep 22, 2021
56da550
Wasm.Build.Tests: Disable net5.0 because they can't be tested right now
radical Sep 23, 2021
ed2cc52
Bump sdk for workload testing to 6.0.100-rc.2.21473.29
radical Sep 23, 2021
94110b3
[wasm] Error for undefined symbols only when publishing
radical Sep 24, 2021
3f7acdc
[wasm] PInvokeTableGenerator: Add support for variadic functions
radical Sep 24, 2021
bfce53a
[wasm] Handle pinvokes with function pointers
radical Sep 24, 2021
35d8bb8
Merge remote-tracking branch 'origin/release/6.0-rc2' into fixes-rc2
radical Sep 24, 2021
a5a05dd
[wasm] PInvokeTableGenerator: handle pinvokes with function pointers
radical Sep 25, 2021
8d87404
add missing variadic.{c,o}
radical Sep 25, 2021
c2174f3
disable unrelated builds
radical Sep 25, 2021
e5199ed
Merge remote-tracking branch 'origin/release/6.0-rc2' into fixes-rc2
radical Sep 25, 2021
5413e54
Revert "disable unrelated builds"
radical Sep 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't set optimization defaults for Debug config, when publishing
  • Loading branch information
@radical
radical committed Sep 22, 2021
commit 67cda93c70459ef671c86d8287e54b686eec89fc
4 changes: 2 additions & 2 deletions src/mono/wasm/build/WasmApp.Native.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
<PropertyGroup>
<_MonoAotCrossCompilerPath>@(MonoAotCrossCompiler->WithMetadataValue('RuntimeIdentifier','browser-wasm'))</_MonoAotCrossCompilerPath>
<_EmccDefaultFlagsRsp>$([MSBuild]::NormalizePath($(_WasmRuntimePackSrcDir), 'emcc-default.rsp'))</_EmccDefaultFlagsRsp>
<WasmNativeStrip Condition="'$(WasmNativeStrip)' == '' and '$(Configuration)' == 'Debug'">false</WasmNativeStrip>
<WasmNativeStrip Condition="'$(WasmNativeStrip)' == '' and '$(Configuration)' == 'Debug' and '$(WasmBuildingForNestedPublish)' != 'true'">false</WasmNativeStrip>
<WasmNativeStrip Condition="'$(WasmNativeStrip)' == ''">true</WasmNativeStrip>
<WasmNativeDebugSymbols Condition="'$(WasmNativeDebugSymbols)' == ''">true</WasmNativeDebugSymbols>
<WasmLinkIcalls Condition="'$(WasmLinkIcalls)' == ''">$(WasmBuildNative)</WasmLinkIcalls>
Expand All @@ -157,7 +157,7 @@

<_EmccAssertionLevelDefault>0</_EmccAssertionLevelDefault>
<_EmccOptimizationFlagDefault Condition="'$(_WasmDevel)' == 'true'">-O0 -s ASSERTIONS=$(_EmccAssertionLevelDefault)</_EmccOptimizationFlagDefault>
<_EmccOptimizationFlagDefault Condition="'$(_EmccOptimizationFlagDefault)' == '' and '$(Configuration)' == 'Debug'">-O1</_EmccOptimizationFlagDefault>
<_EmccOptimizationFlagDefault Condition="'$(_EmccOptimizationFlagDefault)' == '' and '$(Configuration)' == 'Debug' and '$(WasmBuildingForNestedPublish)' != 'true'">-O1</_EmccOptimizationFlagDefault>
<_EmccOptimizationFlagDefault Condition="'$(_EmccOptimizationFlagDefault)' == ''">-Oz</_EmccOptimizationFlagDefault>

<EmccCompileOptimizationFlag Condition="'$(EmccCompileOptimizationFlag)' == ''">$(_EmccOptimizationFlagDefault)</EmccCompileOptimizationFlag>
Expand Down