Skip to content

Obsolete thumbtacked AssemblyName properties #59522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffhandley merged 8 commits into from
Nov 16, 2021
Merged

Obsolete thumbtacked AssemblyName properties #59522

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
52cf265
Obsolete thumbtacked AssemblyName properties
i3arnon Sep 23, 2021
ec9f7ae
Ignore obsoletion
i3arnon Sep 23, 2021
486b875
Fix pragma
i3arnon Sep 23, 2021
9f05e44
Merge the AssemblyName member obsoletions into a single diagnostic id
jeffhandley Nov 15, 2021
ff6d7bc
Merge branch 'main' into assembley-name. Update to SYSLIB0037 to addr…
jeffhandley Nov 15, 2021
8455593
Fix pragma to use updated diagnostic id
jeffhandley Nov 15, 2021
b0ee59a
Suppress SYSLIB0037 in reflection tests
jeffhandley Nov 15, 2021
8d62a80
Suppress SYSLIB0037 warnings
jeffhandley Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Suppress SYSLIB0037 warnings
  • Loading branch information
@jeffhandley
jeffhandley committed Nov 15, 2021
commit 8d62a802eb91bdcfe212f7d86552cf0750d1d354
2 changes: 2 additions & 0 deletions ...s/System.Reflection.Metadata/src/System/Reflection/Metadata/MetadataReader.netstandard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ internal AssemblyName GetAssemblyName(StringHandle nameHandle, Version version,
{
Version = version,
CultureName = cultureName,
#pragma warning disable SYSLIB0037 // AssemblyName.HashAlgorithm is obsolete
HashAlgorithm = hashAlgorithm,
#pragma warning restore
Flags = GetAssemblyNameFlags(flags),
ContentType = GetContentTypeFromAssemblyFlags(flags)
};
Expand Down
2 changes: 2 additions & 0 deletions ...lection.MetadataLoadContext/src/System/Reflection/TypeLoading/General/AssemblyNameData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ public AssemblyName CreateAssemblyName()
Version = Version,
CultureName = CultureName,
ContentType = ContentType,
#pragma warning disable SYSLIB0037 // AssemblyName members HashAlgorithm and ProcessorArchitecture are obsolete
HashAlgorithm = HashAlgorithm,
ProcessorArchitecture = ProcessorArchitecture
#pragma warning restore
};

// Yes, *we* have to clone the array. AssemblyName.SetPublicKey() violates framework guidelines and doesn't make a copy.
Expand Down