Skip to content

[release/6.0-rc2] [wasm][debugger] Reusing buffer to avoid allocate every debugger message #59523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anipik merged 4 commits into from
Sep 24, 2021
Merged

[release/6.0-rc2] [wasm][debugger] Reusing buffer to avoid allocate every debugger message #59523

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35136f2
Reusing buffer to avoid allocate every debugger message.
thaystg Sep 22, 2021
48896fb
Fixing what was suggested by @radical.
thaystg Sep 22, 2021
0a2a4e3
cleaning code.
thaystg Sep 22, 2021
6b4066a
Changing what was suggested by @radical
thaystg Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleaning code.
  • Loading branch information
@thaystg
thaystg authored and github-actions committed Sep 23, 2021
commit 0a2a4e36cb7ef3ff9861160b822fd99e4677a995
8 changes: 4 additions & 4 deletions src/mono/wasm/runtime/library_mono.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,10 +589,10 @@ var MonoSupportLib = {
Module._free (this.debugger_buffer);
else
this.debugger_buffer_len = 256;
var length = command_parameters.length > this.debugger_buffer_len ? command_parameters.length : this.debugger_buffer_len;
this.debugger_buffer = Module._malloc (length);
this.heap_bytes = new Uint8Array (Module.HEAPU8.buffer, this.debugger_buffer, length);
this.debugger_buffer_len = length;
if (this.debugger_buffer_len < command_parameters.length)
this.debugger_buffer_len = command_parameters.length;
this.debugger_buffer = Module._malloc (this.debugger_buffer_len);
this.heap_bytes = new Uint8Array (Module.HEAPU8.buffer, this.debugger_buffer, this.debugger_buffer_len);
}
this.heap_bytes.set(this._base64_to_uint8 (command_parameters));
},
Expand Down