[Release/6.0] Throw error if assembly version for ref pack assemblies doesnot match assembly version shipped in 6.0.0

[Anipik]

This step is being added as an extra precaution to avoid incrementing the assembly versions for assemblies in the ref pack.
We already automatically calculate it.

[ghost]

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This step is being added as an extra precaution to avoid incrementing the assembly versions for assemblies in the ref pack.
We already automatically calculate it.

Author:	Anipik
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[Anipik]

The failure be like this

C:\git\runtime\eng\packaging.targets(261,5): error : AssemblyVersion should match last released assembly version 6.0.0.0 
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:04.82

C:\git\runtime>dotnet build src\librarie

[safern]

Maybe include the project on the error for easier diagnostic?

[Anipik]

I think the error got trimmed. The eol contains the csproj name

C:\git\runtime\eng\packaging.targets(262,5): error : AssemblyVersion should match last released assembly version 6.0.0.0 [C:\git\runtime\src\libraries\System.Diagnostics.EventLog\src\System.Diagnostics.EventLog.csproj]

[Anipik]

cc @safern @ViktorHofer can you approve this one.

[Anipik]

/backport to main

[github-actions]

Started backporting to main: https://github.com/dotnet/runtime/actions/runs/1270845102

[ViktorHofer]

This only runs for source assemblies. I assume that is desired?

[Anipik]

yes we never change ref assembly versions. They are pinned.

[ViktorHofer]

I assumed this code piece prevents someone from overriding the assembly version. If that's the case, what happens when someone overrides the assembly version in a library's Directory.Build.props file? Wouldn't the ref assembly be overridden then as well?

[safern]

I thought that _AssemblyInTargetingPack was only set to true on ref assemblies as Targeting Pack is the term for the ref pack and runtime pack for the package that carries the source assemblies.

[Anipik]

If that's the case, what happens when someone overrides the assembly version in a library's Directory.Build.props file?

i hope to catch these in the code review. This was basically to test the automatic update of assembly version that we do for the source assembies

[Anipik]

_AssemblyInTargetingPack is true for assemblies that in ref pack but we version source assemblies using this property. ref assemblies are always pinned.