Skip to content

Conversation

@mateoatr
Copy link
Contributor

Takes the changes from #55225. This should fix #59531.

@ghost
Copy link

ghost commented Sep 23, 2021

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Takes the changes from #55225. This should fix #59531.

Author: mateoatr
Assignees: -
Labels:

area-AssemblyLoader-coreclr

Milestone: -

@elinor-fung
Copy link
Member

elinor-fung commented Sep 24, 2021

Takes the changes from #55225.

Minor clarification: I believe the key part is from 77da330 - which #55225 was on top of, so the full fix is here.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. @Anipik this is a tell mode infra change (test). Can you merge once there is a good time?
@mateoatr is this change needed to unblock a failing CI?

@elinor-fung
Copy link
Member

These tests are run on PR, so any PR after #59428 got merged - for example, #59476 and #59548 - will hit this (all CoreCLR runtime test legs fail).

@jeffschwMSFT
Copy link
Member

@mateoatr can you take a look at the CI failures?

@agocke
Copy link
Member

agocke commented Sep 24, 2021

Failing CI was just network errors -- reran and everything's passed

@Anipik Anipik merged commit 4916178 into dotnet:release/5.0 Sep 24, 2021
@NikolaMilosavljevic
Copy link
Member

These tests are run on PR, so any PR after #59428 got merged - for example, #59476 and #59548 - will hit this (all CoreCLR runtime test legs fail).

@elinor-fung how can I get my PR (#59548) to succeed - what would be the steps?

@elinor-fung
Copy link
Member

@NikolaMilosavljevic I think closing and re-opening the PR should make it redo the merge against latest (that has this change) and test against that. Alternately, explicitly rebasing your branch to the latest release/5.0 and pushing it up would definitely do it.

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic I think closing and re-opening the PR should make it redo the merge against latest (that has this change) and test against that. Alternately, explicitly rebasing your branch to the latest release/5.0 and pushing it up would definitely do it.

Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants