Skip to content

FileSystem.Unix: improve CopyFile. #59695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffhandley merged 9 commits into from
Nov 15, 2021
Merged

FileSystem.Unix: improve CopyFile. #59695

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e2d3577
FileSystem.Unix: improve CopyFile.
tmds Sep 28, 2021
712db40
Don't FICLONE for zero sourceLength
tmds Oct 20, 2021
3fd621d
PR feedback
tmds Oct 26, 2021
b7ab817
When using sendfile, don't loop when source file gets truncated.
tmds Oct 26, 2021
9be3b2f
Fall through when FICLONE fails.
tmds Oct 26, 2021
4e70e52
Don't stop CopyFile_ReadWrite until read returns zero.
tmds Oct 26, 2021
3c95290
Revert all changes to CopyFile_ReadWrite
tmds Oct 28, 2021
5d7cd45
Move comment a few lines up.
tmds Oct 28, 2021
b67b262
Fix unused error.
tmds Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move comment a few lines up.
  • Loading branch information
@tmds
tmds committed Oct 28, 2021
commit 5d7cd45124e76154a5bbebd2b996dad9f705a010
2 changes: 1 addition & 1 deletion src/libraries/Native/Unix/System.Native/pal_io.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,9 +1164,9 @@ int32_t SystemNative_CopyFile(intptr_t sourceFd, intptr_t destinationFd, int64_t
// Certain files (e.g. procfs) may return a size of 0 even though reading them will
// produce data. We use plain read/write for those.
#ifdef FICLONE
// Try copying data using a copy-on-write clone. This shares storage between the files.
if (sourceLength != 0)
{
// Try copying data using a copy-on-write clone. This shares storage between the files.
while ((ret = ioctl(outFd, FICLONE, inFd)) < 0 && errno == EINTR);
copied = ret == 0;
}
Expand Down